isaaccladandClaude
f2019dbb2a
Every click ran three UPDATEs against the same short_links row plus one against the owner's link_wallets row, all inside one transaction. Two consequences: - A popular link serialised its entire traffic through a single row lock. - Locking two rows per transaction meant concurrent clicks on different links of the same owner could take them in opposite orders, so MySQL deadlocked. Production logged 152 deadlocks, 146 of them on one row, surfacing as HTTP 500s to real visitors. With a link now being handed to a very large audience, this is the next thing that falls over, and it is independent of page weight. Counters are now buffered and flushed instead of written inline: - link_clicks stays the source of truth. It is insert-only, so it has no contention no matter how popular a link gets. - Increments accumulate in Redis hashes and drain via link:flush-click-counters, scheduled every minute. The database sees one UPDATE per link per flush instead of four per click. - Draining reads and deletes each hash atomically, so a click landing mid-flush is counted in that batch or the next, never dropped. - --recount rebuilds totals from link_clicks after a Redis loss. If the buffer is unavailable the recorder writes through to the database, keeping today's behaviour (and today's contention) rather than losing counts. Nothing in the click path may break the redirect the visitor actually came for, so the whole recorder is wrapped and failures are logged. Storage sits behind ClickCounterStore so the buffered path is covered by tests rather than silently falling back to write-through when no Redis is present. Also adds the (short_link_id, ip_hash, clicked_at) index. The unique-click check filters on ip_hash but only (short_link_id, clicked_at) was indexed, so every click scanned all of that link's rows in the dedupe window — cost growing with the link's own popularity, the worst possible shape for a link going viral. Tests: 11 new. The load-bearing one asserts the request path issues no UPDATE against short_links or link_wallets at all. Pre-existing suite failures go from 13 to 9; none of the remainder are related. Co-Authored-By: Claude <noreply@anthropic.com>
About Laravel
Laravel is a web application framework with expressive, elegant syntax. We believe development must be an enjoyable and creative experience to be truly fulfilling. Laravel takes the pain out of development by easing common tasks used in many web projects, such as:
- Simple, fast routing engine.
- Powerful dependency injection container.
- Multiple back-ends for session and cache storage.
- Expressive, intuitive database ORM.
- Database agnostic schema migrations.
- Robust background job processing.
- Real-time event broadcasting.
Laravel is accessible, powerful, and provides tools required for large, robust applications.
Learning Laravel
Laravel has the most extensive and thorough documentation and video tutorial library of all modern web application frameworks, making it a breeze to get started with the framework. You can also check out Laravel Learn, where you will be guided through building a modern Laravel application.
If you don't feel like reading, Laracasts can help. Laracasts contains thousands of video tutorials on a range of topics including Laravel, modern PHP, unit testing, and JavaScript. Boost your skills by digging into our comprehensive video library.
Laravel Sponsors
We would like to extend our thanks to the following sponsors for funding Laravel development. If you are interested in becoming a sponsor, please visit the Laravel Partners program.
Premium Partners
Contributing
Thank you for considering contributing to the Laravel framework! The contribution guide can be found in the Laravel documentation.
Code of Conduct
In order to ensure that the Laravel community is welcoming to all, please review and abide by the Code of Conduct.
Security Vulnerabilities
If you discover a security vulnerability within Laravel, please send an e-mail to Taylor Otwell via taylor@laravel.com. All security vulnerabilities will be promptly addressed.
License
The Laravel framework is open-sourced software licensed under the MIT license.